Simplify program loading error handling #2604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
refactor/remove-account-found
branch
from
f1ac8a6 to
04dcc64
Compare
jstarry
force-pushed
the
refactor/remove-account-found
branch
from
04dcc64 to
b51ce5e
Compare
|
All And yes, it is true that the entire block of program account checking during transaction account loading can be removed / deferred to runtime. I already have something in mind but there are lots of interacting components and I want to spend more time looking for a clean solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's redundant to try to return an error for when programs are not found versus when they are not executable because there are no cases in which a program is not found and is somehow executable.
Summary of Changes
Simplify program loading so that we don't need to track whether accounts existed during loading. We can instead rely on whether the program account is executable.
Fixes #