v2.0: fix: send votes to the immediate next leader (backport of #2607) #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: send votes to the immediate next leader * feedback (cherry picked from commit f4e2fa9)
behzadnouri
approved these changes
Aug 16, 2024
sakridge
reviewed
Aug 16, 2024
| // Attempt to send our vote transaction to the leaders for the next few slots | ||
| const UPCOMING_LEADER_FANOUT_SLOTS: u64 = FORWARD_TRANSACTIONS_TO_LEADER_AT_SLOT_OFFSET; | ||
| #[cfg(test)] | ||
| static_assertions::const_assert_eq!(UPCOMING_LEADER_FANOUT_SLOTS, 2); |
There was a problem hiding this comment.
Is there data on why 2 is chosen versus any other number? Also I'm not sure re-using this makes sense. It seems like an offset not a boundary for forwarding.
There was a problem hiding this comment.
2 offset slots is the current behavior of forwarding. This patch minimally changes behavior by additionally sending to the leader at offset spot 1.
Of course we should look closer at forwarding in the future but this change is an incremental improvement on what we have already been doing
sakridge
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Votes are always sent to the "forward leader" which is defined as the leader of the slot which is 2 slots beyond our latest poh clock slot. This means that a vote for the third slot of a given leader's slot span will always be sent to the following leader for inclusion in the first slot of that leader's slot span. This adds an unnecessary slot of latency to votes because the vote could potentially land in current leader's fourth slot.
Summary of Changes
Fixes #
This is an automatic backport of pull request #2607 done by [Mergify](https://mergify.com).