CI: Disable downstream anchor builds #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem With solana-labs/solana-program-library#7148, spl-token-2022 has moved from using solana-zk-token-sdk to solana-zk-sdk, which is a major breaking change. Certain agave and anchor crates are depending on the re-export solana-zk-token-sdk in spl-token-2022, which is no longer present. This change is causing the downstream Anchor job to fail, since the patched version of spl-token-2022 is no longer compatible. #### Summary of changes Until new major versions of the SPL crates are available used by the Agave monorepo, disable the downstream anchor job.
|
Merging early since the job was properly skipped |
|
do we need to bp this (maybe just 2.0)? |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2024
#### Problem With solana-labs/solana-program-library#7148, spl-token-2022 has moved from using solana-zk-token-sdk to solana-zk-sdk, which is a major breaking change. Certain agave and anchor crates are depending on the re-export solana-zk-token-sdk in spl-token-2022, which is no longer present. This change is causing the downstream Anchor job to fail, since the patched version of spl-token-2022 is no longer compatible. #### Summary of changes Until new major versions of the SPL crates are available used by the Agave monorepo, disable the downstream anchor job. (cherry picked from commit 3b9e7a3) # Conflicts: # .github/workflows/downstream-project-anchor.yml
joncinque
added a commit
that referenced
this pull request
Aug 17, 2024
* CI: Disable downstream anchor builds (#2629) #### Problem With solana-labs/solana-program-library#7148, spl-token-2022 has moved from using solana-zk-token-sdk to solana-zk-sdk, which is a major breaking change. Certain agave and anchor crates are depending on the re-export solana-zk-token-sdk in spl-token-2022, which is no longer present. This change is causing the downstream Anchor job to fail, since the patched version of spl-token-2022 is no longer compatible. #### Summary of changes Until new major versions of the SPL crates are available used by the Agave monorepo, disable the downstream anchor job. (cherry picked from commit 3b9e7a3) # Conflicts: # .github/workflows/downstream-project-anchor.yml * Fix merge conflicts --------- Co-authored-by: Jon C <[email protected]>
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
#### Problem With solana-labs/solana-program-library#7148, spl-token-2022 has moved from using solana-zk-token-sdk to solana-zk-sdk, which is a major breaking change. Certain agave and anchor crates are depending on the re-export solana-zk-token-sdk in spl-token-2022, which is no longer present. This change is causing the downstream Anchor job to fail, since the patched version of spl-token-2022 is no longer compatible. #### Summary of changes Until new major versions of the SPL crates are available used by the Agave monorepo, disable the downstream anchor job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With solana-labs/solana-program-library#7148, spl-token-2022 has moved from using solana-zk-token-sdk to solana-zk-sdk, which is a major breaking change. Certain agave and anchor crates are depending on the re-export solana-zk-token-sdk in spl-token-2022, which is no longer present. This change is causing the downstream Anchor job to fail, since the patched version of spl-token-2022 is no longer compatible.
Summary of changes
Until new major versions of the SPL crates are available used by the Agave monorepo, disable the downstream anchor job.