impl Deref for RuntimeTransaction #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Aug 20, 2024
| @@ -64,7 +64,13 @@ impl<T: StaticMetaAccess> StaticMeta for RuntimeTransaction<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<M: DynamicMetaAccess> DynamicMeta for RuntimeTransaction<M> {} | |||
| impl<T: DynamicMetaAccess> DynamicMeta for RuntimeTransaction<T> {} | |||
There was a problem hiding this comment.
Only changed M to T here to be consistent with the other generic parameter naming in this file.
apfitzge
force-pushed
the
runtime_transaction_as_ref
branch
from
663bf41 to
1597237
Compare
apfitzge
changed the title
apfitzge
force-pushed
the
runtime_transaction_as_ref
branch
from
1597237 to
809a06c
Compare
tao-stones
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Derefis the more appropriate trait since we wantRuntimeTransactionto directly be able to call functions ofT. Not having to call.as_ref()everywhere.Summary of Changes
DerefforRuntimeTransaction<T>so thatRuntimeTransactionis able to access transaction informationFixes #