next attempt at packing algorithm #2790
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
4aug50
branch
5 times, most recently
from
2928c2c to
32e322b
Compare
|
I think this is the right idea. We have a few pieces we can put in independently. We are doing longer term testing on this. |
|
@HaoranYi @brooksprumo we may want a cli arg that allows us to say how many ancient storages we want to allow to be open? Maybe default to 100k? So, the ancient boundary and the # storages allowd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Longer term testing of ancient packing has indicated some non-ideal behaviors in mnb data.
Summary of Changes
Change the tuning and allow shrink to shrink 'ancient' storages so that cold accounts remain together.
Fixes #