Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: Bump platform tools version (backport of #2745) #2799

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 30, 2024

Problem

Platform tools v1.42 is dated and still brings Rust 1.75.

Summary of Changes

Bump the tools version to v1.43, which brings Rust 1.79.


This is an automatic backport of pull request #2745 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 30, 2024 14:13
@mergify mergify bot added the conflicts label Aug 30, 2024
Copy link
Author

mergify bot commented Aug 30, 2024

Cherry-pick of ad6002f has failed:

On branch mergify/bp/v2.0/pr-2745
Your branch is up to date with 'origin/v2.0'.

You are currently cherry-picking commit ad6002f90b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   programs/sbf/rust/ro_modify/src/lib.rs
	modified:   sdk/cargo-build-sbf/src/main.rs
	modified:   sdk/sbf/scripts/install.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdk/program/Cargo.toml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

* Bump platform tools version

* Remove unused struct
@LucasSte
Copy link

The reason I'm back porting this change is to bring a newer version of Rust to developers. We currently ship Rust 1.75, released in December 2023 (8 months old). This PR bumps the version to 1.79, released in June 2024.

@LucasSte LucasSte force-pushed the mergify/bp/v2.0/pr-2745 branch from f70139f to 6c43f43 Compare August 30, 2024 14:25
@LucasSte LucasSte force-pushed the mergify/bp/v2.0/pr-2745 branch from e809183 to aed340b Compare August 30, 2024 14:38
@LucasSte LucasSte force-pushed the mergify/bp/v2.0/pr-2745 branch from aed340b to d5767d4 Compare August 30, 2024 18:43
@LucasSte
Copy link

LucasSte commented Sep 3, 2024

Closing this PR as Agave v2.0 is locked on Rust 1.78. Bumping the platform tools to Rust 1.79 while the rest of the validator is behind may bring unintended problems.

@LucasSte LucasSte closed this Sep 3, 2024
@LucasSte LucasSte deleted the mergify/bp/v2.0/pr-2745 branch September 3, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant