unref accounts in shink and pack when we're committed #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
reviewed
Sep 3, 2024
jeffwashington
commented
Sep 3, 2024
jeffwashington
commented
Sep 3, 2024
|
@brooksprumo go ahead and turn your eyes on this when you can, please. I believe we have a race condition in master today that this fixes. |
|
Rebase to master. No functional change. |
jeffwashington
commented
Sep 4, 2024
jeffwashington
commented
Sep 4, 2024
jeffwashington
commented
Sep 4, 2024
added 3 commits
September 4, 2024 13:55
This reverts commit f8aefe0.
brooksprumo
reviewed
Sep 4, 2024
brooksprumo
reviewed
Sep 4, 2024
brooksprumo
reviewed
Sep 4, 2024
| @@ -4159,7 +4158,7 @@ impl AccountsDb { | |||
| .for_each(|stored_accounts| { | |||
| let LoadAccountsIndexForShrink { | |||
| alive_accounts, | |||
| mut unrefed_pubkeys, | |||
| pubkeys_to_unref: mut unrefed_pubkeys, | |||
There was a problem hiding this comment.
nit: Here's another unrefed_pubkeys that can be renamed. (And the others in this function.)
It looks like ShrinkCollect has an unrefed_pubkeys field too. That can be renamed. IMO a subsequent PR is fine too.
brooksprumo
approved these changes
Sep 4, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* unref accounts in shink and pack when we're committed * remove bad comments * rewrite shrink_ancient_fail_ref test * fix comments * fix a test * fix another test * fmt * del invalid comments * reviews: move log to new PR. * Revert "reviews: move log to new PR." This reverts commit f8aefe0. * fix comments * revert log content * pr: rename * pr: more rename --------- Co-authored-by: HaoranYi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
there is a race with shrink and packing (and ancient appending) where we unref a dead account while preparing but then decide to not act on the slot. This addrefs the accounts. In the meantime, a zero lamport single ref account may have been prepared for marking dead. This race leads to refcount issues.
Summary of Changes
Only unref when we are committed to making the account dead. This is a much cleaner architecture. The index lookup performance we were worried about will be handled by the new scanning model that is rolling out soon.
Fixes #