runtime-transaction: get_signature_details #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
changed the title
apfitzge
commented
Sep 5, 2024
| // array of slots for all possible static and sanitized program_id_index, | ||
| // each slot indicates if a program_id_index has not been checked, or is | ||
| // already checked with result that can be reused. | ||
| flags: [Option<ProgramIdStatus>; FILTER_SIZE as usize], |
There was a problem hiding this comment.
Not all variants are used in enum, so Option here should not add additional byte.
tao-stones
reviewed
Sep 9, 2024
| } | ||
|
|
||
| #[inline] | ||
| fn get_num_signatures_in_instruction(instruction: &SVMInstruction) -> u8 { |
apfitzge
force-pushed
the
runtime_transaction_get_signature_details
branch
from
dd87307 to
f834940
Compare
apfitzge
commented
Sep 25, 2024
| @@ -433,6 +433,18 @@ pub struct TransactionSignatureDetails { | |||
| } | |||
|
|
|||
| impl TransactionSignatureDetails { | |||
| pub fn new( | |||
There was a problem hiding this comment.
this doesn't strictly need to be part of this PR any more.
but it is necessary if we want to take the precompile details and turn it into the full details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
get_signature_detailstoRuntimeTransaction(eventually this will be stashed)RuntimeTransactionFixes #