Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses Offset in SlotOffsets #2890

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Uses Offset in SlotOffsets #2890

merged 1 commit into from
Sep 13, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Sep 10, 2024 •
edited
Loading

Problem

The SlotOffsets type alias doesn't use the Offset type alias for the offset type.

Summary of Changes

Use Offset.

@brooksprumo brooksprumo self-assigned this Sep 10, 2024
@brooksprumo brooksprumo marked this pull request as ready for review September 13, 2024 13:36
HaoranYi
HaoranYi approved these changes Sep 13, 2024
View reviewed changes
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@brooksprumo brooksprumo merged commit 031b1eb into anza-xyz:master Sep 13, 2024
40 checks passed
@brooksprumo brooksprumo deleted the slot-offsets branch September 13, 2024 14:19
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@brooksprumo @ray-kast
Uses Offset in SlotOffsets (anza-xyz#2890)
19af9dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoranYi HaoranYi HaoranYi approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @HaoranYi