Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses IntSet in AccountSlots #2892

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

brooksprumo
Copy link

Problem

AccountSlots is a map of pubkey to slots. The set of slots does not need cryptographic security, so it can use IntSet instead of HashSet for better performance.

Summary of Changes

Replace HashSet with IntSet.

@brooksprumo brooksprumo self-assigned this Sep 10, 2024
@brooksprumo brooksprumo marked this pull request as ready for review September 11, 2024 12:38
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit c8c6d2a into anza-xyz:master Sep 12, 2024
40 checks passed
@brooksprumo brooksprumo deleted the no-hash/account-slots branch September 12, 2024 18:34
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants