remove outdated solana-ledger-udev binary #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good to me! Can you also add a # Solana Remote Wallet
Library for interacting with "remote" wallets, meaning any wallet where the private key bytes are not directly available, such as Ledger devices.
## Ledger udev-rules
In order to use a Ledger device on Linux machines, users must apply certain udev rules. These are available at the [udev-rules repository](https://github.com/LedgerHQ/udev-rules) maintained by the Ledger team. |
Currently there exists a solana-ledger-udev binary which creates a udev rules file in /etc/udev/rules.d/20-hw1.rules and reloads the udev rules. This might work on some systems and not on others (e.g., NixOS) and makes unnecessary assumptions about the currently running system. These rules are also outdated and we're probably better off referencing the upstream repository rules maintained by Ledger https://github.com/LedgerHQ/udev-rules and encouraging people to integrate them into their system.
Add a README to remote-wallet which explains why this library exists and where to get ledger udev rules from.
Managarmrr
force-pushed
the
fixup/ledger-udev
branch
from
9fff8b7 to
d14c71a
Compare
|
Sure, added the README. |
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* remove outdated solana-ledger-udev binary Currently there exists a solana-ledger-udev binary which creates a udev rules file in /etc/udev/rules.d/20-hw1.rules and reloads the udev rules. This might work on some systems and not on others (e.g., NixOS) and makes unnecessary assumptions about the currently running system. These rules are also outdated and we're probably better off referencing the upstream repository rules maintained by Ledger https://github.com/LedgerHQ/udev-rules and encouraging people to integrate them into their system. * remote-wallet: add README Add a README to remote-wallet which explains why this library exists and where to get ledger udev rules from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there exists a solana-ledger-udev binary which creates a udev rules file in /etc/udev/rules.d/20-hw1.rules and reloads the udev rules.
This might work on some systems and not on others (e.g., NixOS) and makes unnecessary assumptions about the currently running system.
These rules are also outdated and we're probably better off referencing the upstream repository rules maintained by Ledger and encouraging people to integrate them into their system.