forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract solana-cpi crate #2981
Merged
Merged
extract solana-cpi crate #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
cpi-crate
branch
2 times, most recently
from
September 27, 2024 08:02
b7c9ac1
to
d74ee32
Compare
kevinheavey
force-pushed
the
cpi-crate
branch
2 times, most recently
from
October 14, 2024 13:46
85b266d
to
6d8fcd1
Compare
kevinheavey
force-pushed
the
cpi-crate
branch
from
October 22, 2024 10:10
6d8fcd1
to
a0d7889
Compare
joncinque
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Mostly small stuff
joncinque
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just needs a rebase, @yihau can you accept ownership of solana-cpi
?
Co-authored-by: Jon C <[email protected]>
Co-authored-by: Jon C <[email protected]>
Co-authored-by: Jon C <[email protected]>
…g(target_os = "solana")] for this to work)
Co-authored-by: Jon C <[email protected]>
kevinheavey
force-pushed
the
cpi-crate
branch
from
October 23, 2024 11:14
7227094
to
7df7787
Compare
kevinheavey
added
the
automerge
automerge Merge this Pull Request automatically once CI passes
label
Oct 23, 2024
joncinque
approved these changes
Oct 25, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* extract cpi crate * unused import * fmt * move sol_invoke_signed_c to cpi crate * minimize solana_program use in doc comment Co-authored-by: Jon C <[email protected]> * minimize solana_program use in doc comment Co-authored-by: Jon C <[email protected]> * fix doc link Co-authored-by: Jon C <[email protected]> * fix entrypoint usage in doc examples * add static assertion for inlined SUCCESS const (needed to remove #[cfg(target_os = "solana")] for this to work) * fix doc link Co-authored-by: Jon C <[email protected]> * sort deps --------- Co-authored-by: Jon C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::program
is a vital component of onchain programs and it needs to be made available outside ofsolana_program
.This branches off #2924 so that needs to be merged first
Summary of Changes
solana-cpi
crate with inline syscall stubs that cannot be overwrittensolana-cpi
insolana_program::program
so the syscall stubs can be overwritten as before