gossip: reduce votes stored per validator from 31 to 2 #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
changed the title
AshwinSekar
force-pushed
the
gossip-limit-votes
branch
from
cd79528 to
3ae0155
Compare
AshwinSekar
changed the title
AshwinSekar
force-pushed
the
gossip-limit-votes
branch
from
3ae0155 to
e341e02
Compare
AshwinSekar
force-pushed
the
gossip-limit-votes
branch
from
e341e02 to
17eca89
Compare
AshwinSekar
force-pushed
the
gossip-limit-votes
branch
from
17eca89 to
769ac39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that votes are no longer incremental, it is not necessary for gossip to hold 31 votes per validator.
Summary of Changes
Instead store
MAX_VOTES = 2votes per validator. With the improvement to OC tracking in #3136, I believe that we will be fine with only 1 vote, however 2 votes might be beneficial in the case of refreshed votes.Note: DO NOT MERGE until tested in sim clusters