Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades serde_with to 3.9.0 #2984

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Upgrades serde_with to 3.9.0 #2984

merged 1 commit into from
Sep 25, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Sep 25, 2024 •
edited
Loading

The serde_with crate is very old. Version 2.3.3 was release April 2023. Since automatic dependency bumps do not increment major version, we must do it manually.

Some benefits:

  • improved build time (see v3.6.1)
  • adds hashbrown support (see v3.3.0)
  • upgrades the base64 inner dependency (see v3.0.0)

@brooksprumo brooksprumo marked this pull request as ready for review September 25, 2024 17:35
@brooksprumo brooksprumo requested a review from yihau September 25, 2024 17:35
yihau
yihau approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@brooksprumo brooksprumo merged commit d22e8e3 into anza-xyz:master Sep 25, 2024
51 checks passed
@brooksprumo brooksprumo deleted the deps/serde-with branch September 25, 2024 19:04
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@brooksprumo @ray-kast
Upgrades serde_with to 3.9.0 (anza-xyz#2984)
9a3d059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihau yihau yihau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @yihau