Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeTransactions: implement SVM traits #2987

Merged
merged 1 commit into from
Sep 30, 2024
Merged

RuntimeTransactions: implement SVM traits #2987

merged 1 commit into from
Sep 30, 2024

Conversation

apfitzge
Copy link

Problem

  • Many of internal functions are generic over SVMMessage or SVMTransaction
  • If we have a RuntimeTransaction wrapped transaction to cache metadata, then it cannot be passed

Summary of Changes

  • Implement the traits for RuntimeTransaction if the inner type implements

Blocked by #2983,#2986

Fixes #

@apfitzge apfitzge force-pushed the runtime_transaction_svm_traits branch from 43dbeb2 to 0336010 Compare September 27, 2024 10:04
@apfitzge apfitzge requested a review from tao-stones September 27, 2024 14:10
@apfitzge apfitzge marked this pull request as ready for review September 27, 2024 14:10
tao-stones
tao-stones approved these changes Sep 27, 2024
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to support SVMMessage/SVMTransaction.

@apfitzge apfitzge merged commit e490ae9 into anza-xyz:master Sep 30, 2024
40 checks passed
@apfitzge apfitzge deleted the runtime_transaction_svm_traits branch September 30, 2024 13:01
@apfitzge apfitzge mentioned this pull request Sep 30, 2024
Merged
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@apfitzge @ray-kast
RuntimeTransactions: implement SVM traits (anza-xyz#2987)
381fb85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @tao-stones