Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract system-instruction crate #3007

Closed

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Sep 27, 2024

Problem

Pulling out solana_program::system_instruction is useful in itself and is a prerequisite for pulling out solana_program::message

This branches off #2348 so that needs to be merged first

Summary of Changes

  • Extract solana-system-instruction crate and re-export it in solana-program
  • Remove thiserror and num_derive from the new crate and replace with expanded macros
  • Move solana_program::wasm::system_instruction to solana_system_instruction::wasm

@kevinheavey kevinheavey force-pushed the extract-system-instruction branch 4 times, most recently from eb55c82 to 7dfa039 Compare October 5, 2024 10:09
@kevinheavey kevinheavey force-pushed the extract-system-instruction branch 2 times, most recently from 2415f3b to 424215a Compare October 8, 2024 08:06
@kevinheavey kevinheavey force-pushed the extract-system-instruction branch 2 times, most recently from aaae145 to 46ce174 Compare October 14, 2024 13:15
@kevinheavey kevinheavey marked this pull request as ready for review October 14, 2024 13:15
@kevinheavey kevinheavey requested a review from joncinque October 14, 2024 13:28
@kevinheavey kevinheavey force-pushed the extract-system-instruction branch from 46ce174 to aa588fb Compare October 14, 2024 14:37
@kevinheavey kevinheavey force-pushed the extract-system-instruction branch 6 times, most recently from f180053 to d7d7f5c Compare October 29, 2024 13:38
@kevinheavey kevinheavey force-pushed the extract-system-instruction branch from d7d7f5c to ead7942 Compare October 29, 2024 22:13
@joncinque
Copy link

Hey @kevinheavey, we're planning to move the native program instruction creators into separate repos, to be eventually paired with their BPF implementations. You can see the progress on that at solana-program/system#16 -- although, skimming through your PR, I think he might have used it as strong inspiration.

Do you want to give a review over there?

@kevinheavey kevinheavey closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants