forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract system-instruction crate #3007
Closed
kevinheavey
wants to merge
13
commits into
anza-xyz:master
from
kevinheavey:extract-system-instruction
Closed
Extract system-instruction crate #3007
kevinheavey
wants to merge
13
commits into
anza-xyz:master
from
kevinheavey:extract-system-instruction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-system-instruction
branch
4 times, most recently
from
October 5, 2024 10:09
eb55c82
to
7dfa039
Compare
kevinheavey
force-pushed
the
extract-system-instruction
branch
2 times, most recently
from
October 8, 2024 08:06
2415f3b
to
424215a
Compare
kevinheavey
force-pushed
the
extract-system-instruction
branch
2 times, most recently
from
October 14, 2024 13:15
aaae145
to
46ce174
Compare
kevinheavey
force-pushed
the
extract-system-instruction
branch
from
October 14, 2024 14:37
46ce174
to
aa588fb
Compare
kevinheavey
force-pushed
the
extract-system-instruction
branch
6 times, most recently
from
October 29, 2024 13:38
f180053
to
d7d7f5c
Compare
kevinheavey
force-pushed
the
extract-system-instruction
branch
from
October 29, 2024 22:13
d7d7f5c
to
ead7942
Compare
Hey @kevinheavey, we're planning to move the native program instruction creators into separate repos, to be eventually paired with their BPF implementations. You can see the progress on that at solana-program/system#16 -- although, skimming through your PR, I think he might have used it as strong inspiration. Do you want to give a review over there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pulling out
solana_program::system_instruction
is useful in itself and is a prerequisite for pulling outsolana_program::message
This branches off #2348 so that needs to be merged first
Summary of Changes
solana_program::wasm::system_instruction
tosolana_system_instruction::wasm