Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract solana-bincode crate #3020

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

kevinheavey
Copy link

Problem

solana_program::program_utils (which contains only the limited_deserialize function) is a prerequisite for pulling out solana_program::message, and is used in various other places.

Summary of Changes

  • Move to its own crate and re-export for backwards compatibility

@kevinheavey kevinheavey force-pushed the limited-deserialize-crate branch from efaf811 to 65ccdeb Compare October 1, 2024 08:52
@kevinheavey kevinheavey requested a review from febo October 4, 2024 18:12
Copy link

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we name the crate solana-bincode so we can group any bincode specific helper on it?

@kevinheavey kevinheavey changed the title extract limited-deserialize crate extract solana-bincode crate Oct 8, 2024
@kevinheavey
Copy link
Author

@yihau could you accept the ownership invite for solana-bincode please?

@febo
Copy link

febo commented Oct 9, 2024

Great, thanks! I will wait for the crate-check to pass and then approve it.

@yihau
Copy link
Member

yihau commented Oct 9, 2024

all green!

@febo febo merged commit 6e62af0 into anza-xyz:master Oct 9, 2024
50 checks passed
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
* extract limited-deserialize crate

* rename solana-limited-deserialize to solana-bincode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants