Add hidden CLI arg to control number of shred sigverify threads #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument controls the size of the rayon threadpool that is used to perform signature verification on received shreds. The argument is hidden for now. This change allows configuration of the value, but the default behavior (ie not setting the arg) matches the pre-existing behavior.
steviez
commented
Oct 2, 2024
Comment on lines
+373
to
+374
| tvu_shred_sigverify_threads: NonZeroUsize::new(get_thread_count()) | ||
| .expect("thread count is non-zero"), |
There was a problem hiding this comment.
Having to duplicate this (in addition to calling the function in validator/cli/thread_args.rs is a bit unfortunate, but it was what we did with replay_transactions_threads.
For now, I think I'm ok with it. Eventually, I'd like the solana_rayon_threadlimit crate to go away completely, removing these "extraneous" usages could be tucked in with that
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
…-xyz#3046) The argument controls the size of the rayon threadpool that is used to perform signature verification on received shreds. The argument is hidden for now. This change allows configuration of the value, but the default behavior (ie not setting the arg) matches the pre-existing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#105
Summary of Changes
The argument controls the size of the rayon threadpool that is used to perform signature verification on received shreds. The argument is hidden for now.
This change allows configuration of the value, but the default behavior (ie not setting the arg) matches the pre-existing behavior.