Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LtHash::identity() #3057

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Oct 2, 2024

Problem

One of the valuable properties of the lattice hash is that it has an identity value. Unfortunately this is not exposed explicitly, so using the identity value requires manually spelling out the array with all zeros.

Summary of Changes

Add a const fn to return the LtHash's identity value.

@brooksprumo brooksprumo self-assigned this Oct 2, 2024
@brooksprumo brooksprumo marked this pull request as ready for review October 3, 2024 02:11
@brooksprumo brooksprumo requested a review from HaoranYi October 3, 2024 02:12
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit aed6f36 into anza-xyz:master Oct 3, 2024
38 of 40 checks passed
@brooksprumo brooksprumo deleted the lthash/identity branch October 3, 2024 14:07
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants