Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeTransaction::is_simple_vote_transaction #3099

Merged
merged 1 commit into from
Oct 7, 2024
Merged

RuntimeTransaction::is_simple_vote_transaction #3099

merged 1 commit into from
Oct 7, 2024

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Oct 7, 2024

Problem

Summary of Changes

  • Rename RuntimeTransaction::is_simple_vote_tx to more explicit (and consistent with SanitizedTransaction) is_simple_vote_transaction

Fixes #

@apfitzge apfitzge self-assigned this Oct 7, 2024
@apfitzge apfitzge mentioned this pull request Oct 7, 2024
Merged
@apfitzge apfitzge marked this pull request as ready for review October 7, 2024 21:43
@apfitzge apfitzge requested review from jstarry and tao-stones October 7, 2024 21:44
tao-stones
tao-stones approved these changes Oct 7, 2024
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 1e389f4 into anza-xyz:master Oct 7, 2024
38 checks passed
@apfitzge apfitzge deleted the runtime_transaction_rename branch October 7, 2024 23:42
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@apfitzge @ray-kast
RuntimeTransaction::is_simple_vote_transaction (anza-xyz#3099)
8f776b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

@jstarry jstarry jstarry approved these changes

Assignees

@apfitzge apfitzge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apfitzge @jstarry @tao-stones