Only aggregate heaviest fork at the coordinator. #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen-coding
commented
Oct 9, 2024
wen-coding
commented
- Only aggregate heaviest fork from the coordinator
- Remove the "80% sees 80%" exit condition
- Only exit if stopped
carllin
reviewed
Oct 16, 2024
| @@ -1005,6 +867,15 @@ pub fn wait_for_wen_restart(config: WenRestartConfig) -> Result<()> { | |||
| --no-snapshot-fetch", | |||
| slot, hash, shred_version, | |||
| ); | |||
| if config.cluster_info.id() == config.wen_restart_coordinator { | |||
| aggregate_restart_heaviest_fork( | |||
There was a problem hiding this comment.
why do we need to aggregate on completion here?
There was a problem hiding this comment.
I think this was your suggestion: make the coordinator aggregate heaviest fork at the end, so we know the status of the cluster from watching the coordinator
carllin
previously approved these changes
Oct 16, 2024
carllin
approved these changes
Oct 17, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* Only aggregate heaviest fork for the coordinator, do not exit until asked. * Fix a bad merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.