-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract transaction-context crate #3132
Extract transaction-context crate #3132
Conversation
6b718a4
to
04c3850
Compare
a97f5ff
to
a2ca822
Compare
989ee76
to
f30e79e
Compare
f30e79e
to
cc7162c
Compare
cc7162c
to
518a4f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Just a question on the name of the feature, I think you took the right approach.
I looked for another potential crate to host this type, but it's really used all over the place, so a separate crate makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one last bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @yihau can you accept solana-transaction-context
?
Problem
solana_sdk::transaction_context
imposes asolana_sdk
dep onsolana_transaction_status_client_types
Summary of Changes
full
feature of solana-sdk for code using debug_assertions. Add adebug_assertions
feature to the new crate to replace thefull
feature.