-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract rent-debits crate #3150
Conversation
03b44ff
to
6aaab12
Compare
6aaab12
to
c7499da
Compare
c7499da
to
b382d43
Compare
b382d43
to
04d8412
Compare
bc44160
to
2cf4c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some small things
"sdk/reserved-account-keys", | ||
"sdk/reward-info", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
sdk/rent-debits/Cargo.toml
Outdated
[target.'cfg(target_os = "solana")'.dependencies] | ||
solana-define-syscall = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I might be missing something -- is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- @yihau can you accept solana-rent-debits
?
a284708
to
8595f6d
Compare
Problem
solana_sdk::rent_debits
imposes asolana_sdk
dep onsolana_svm
Summary of Changes
Move to its own crate and re-export with deprecation
This branches off #2971 so that needs to be merged first