Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract rent-debits crate #3150

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Conversation

kevinheavey
Copy link

Problem

solana_sdk::rent_debits imposes a solana_sdk dep on solana_svm

Summary of Changes

Move to its own crate and re-export with deprecation

This branches off #2971 so that needs to be merged first

@kevinheavey kevinheavey marked this pull request as ready for review November 5, 2024 12:25
@kevinheavey kevinheavey force-pushed the extract-rent-debits branch 3 times, most recently from bc44160 to 2cf4c8e Compare November 20, 2024 07:53
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some small things

"sdk/reserved-account-keys",
"sdk/reward-info",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Comment on lines 22 to 23
[target.'cfg(target_os = "solana")'.dependencies]
solana-define-syscall = { workspace = true }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I might be missing something -- is this needed?

sdk/rent-debits/Cargo.toml Show resolved Hide resolved
sdk/rent-debits/src/lib.rs Show resolved Hide resolved
joncinque
joncinque previously approved these changes Nov 21, 2024
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- @yihau can you accept solana-rent-debits?

@joncinque joncinque added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 22, 2024
@joncinque joncinque merged commit 2a9ab0b into anza-xyz:master Nov 22, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants