Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: link openssl statically for Windows (backport of #3118) #3156

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 14, 2024

Problem

a refined version of the timeline for future reference:

Summary of Changes

> ldd solana-test-validator
  	ntdll.dll => /c/Windows/SYSTEM32/ntdll.dll (0x7ffe8ccc0000)
  	KERNEL32.DLL => /c/Windows/System32/KERNEL32.DLL (0x7ffe8b580000)
  	KERNELBASE.dll => /c/Windows/System32/KERNELBASE.dll (0x7ffe8a240000)
  	apphelp.dll => /c/Windows/SYSTEM32/apphelp.dll (0x7ffe88280000)
  	bcryptprimitives.dll => /c/Windows/System32/bcryptprimitives.dll (0x7ffe8ab70000)
  	USER32.dll => /c/Windows/System32/USER32.dll (0x7ffe8b3d0000)
  	win32u.dll => /c/Windows/System32/win32u.dll (0x7ffe8ab40000)
  	POWRPROF.dll => /c/Windows/SYSTEM32/POWRPROF.dll (0x7ffe8a120000)
  	GDI32.dll => /c/Windows/System32/GDI32.dll (0x7ffe8c610000)
  	ucrtbase.dll => /c/Windows/System32/ucrtbase.dll (0x7ffe8a800000)
  	gdi32full.dll => /c/Windows/System32/gdi32full.dll (0x7ffe8a6e0000)
  	RPCRT4.dll => /c/Windows/System32/RPCRT4.dll (0x7ffe8c1f0000)
  	msvcp_win.dll => /c/Windows/System32/msvcp_win.dll (0x7ffe8aaa0000)
  	CRYPT32.dll => /c/Windows/System32/CRYPT32.dll (0x7ffe8a910000)
  	WS2_32.dll => /c/Windows/System32/WS2_32.dll (0x7ffe8b7d0000)
  	ADVAPI32.dll => /c/Windows/System32/ADVAPI32.dll (0x7ffe8b710000)
  	msvcrt.dll => /c/Windows/System32/msvcrt.dll (0x7ffe8b320000)
  	sechost.dll => /c/Windows/System32/sechost.dll (0x7ffe8c640000)
  	bcrypt.dll => /c/Windows/System32/bcrypt.dll (0x7ffe8aa70000)
  	SHLWAPI.dll => /c/Windows/System32/SHLWAPI.dll (0x7ffe8c5b0000)
  	shell32.dll => /c/Windows/System32/shell32.dll (0x7ffe8b8d0000)
  	secur32.dll => /c/Windows/SYSTEM32/secur32.dll (0x7ffe7db70000)
  	ole32.dll => /c/Windows/System32/ole32.dll (0x7ffe8b1e0000)
  	combase.dll => /c/Windows/System32/combase.dll (0x7ffe8c910000)
  	VCRUNTIME140.dll => /c/Windows/SYSTEM32/VCRUNTIME140.dll (0x7ffe7e9a0000)
  	MSVCP140.dll => /c/Windows/SYSTEM32/MSVCP140.dll (0x7ffe7e9c0000)
  	VCRUNTIME140_1.dll => /c/Windows/SYSTEM32/VCRUNTIME140_1.dll (0x7ffe7f450000)
  	CRYPTBASE.DLL => /c/Windows/SYSTEM32/CRYPTBASE.DLL (0x7ffe899b0000)
  	SSPICLI.DLL => /c/Windows/SYSTEM32/SSPICLI.DLL (0x7ffe89bf0000)

* ci: fix windows pipeline

* vendor openssl for windows

* add comment for the workaround

(cherry picked from commit 49d2298)
@mergify mergify bot assigned yihau Oct 14, 2024
@mergify mergify bot requested a review from a team as a code owner October 14, 2024 11:11
@yihau
Copy link
Member

yihau commented Oct 14, 2024

note for @anza-xyz/backport-reviewers : the main purpose of this PR is to fix Windows pipeline

@yihau yihau merged commit c70d9d3 into v2.0 Oct 15, 2024
24 checks passed
@yihau yihau deleted the mergify/bp/v2.0/pr-3118 branch October 15, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants