load_addresses performance #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Oct 15, 2024
| @@ -51,22 +51,20 @@ impl Bank { | |||
| .map_err(|_| AddressLoaderError::SlotHashesSysvarNotFound)?; | |||
|
|
|||
| let mut deactivation_slot = u64::MAX; | |||
| let loaded_addresses = address_table_lookups | |||
| .map(|address_table_lookup| { | |||
| let mut loaded_addresses = LoadedAddresses::default(); | |||
There was a problem hiding this comment.
We could, with some work in higher-level functions, pre-allocate the space for this.
jstarry
reviewed
Oct 16, 2024
| slot_hashes, | ||
| )?; | ||
|
|
||
| // Append to the loaded addresses. |
There was a problem hiding this comment.
Before appending we should reserve space for the number of pushed elements to avoid potentially triggering multiple allocations while pushing a lot of elements.
There was a problem hiding this comment.
👍 used reserve so it will only allocate if necessary.
jstarry
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::load_addressesandBank::load_addresses_from_refallocate inefficiently:LoadedAddressesfor eachMessageAddressTableLookupin themessageLoadedAddressesviacollectinto a singleLoadedAddressesSummary of Changes
LoadedAddressesup front, and load addresses into that table.Fixes #