Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: reuse ff to gate tvc constant update from 8 -> 16 #322

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

AshwinSekar
Copy link

Problem

initial change was not feature gated

Summary of Changes

reuse plumbing feature flag to gate it

Copy link

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

mergify bot commented Mar 19, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@AshwinSekar AshwinSekar added automerge automerge Merge this Pull Request automatically once CI passes and removed v1.18 labels Mar 19, 2024
@AshwinSekar
Copy link
Author

@willhickey I removed the backport label because I'm going to manually backport it along with the original commit #138

@mergify mergify bot merged commit 228413c into anza-xyz:master Mar 19, 2024
48 checks passed
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants