vote: allow block_id to be None until new shred format is rolled out #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#2776 populates the
block_idfor allTowerSyncinstructions.Normally this can only be
Noneif we are voting on our own leader block, however for mainnet and 1.18 clusters, the new shred format is yet to be rolled out, also causing this value to be None.Summary of Changes
Restore compatibility of master to mainnet by removing these assertions. These assertions can be added back in once the new shred format is fully rolled out. The feature flag that enables
TowerSyncis not planned to be activated until after the new shred format is fully rolled out.