Plumb errors through TransactionStatusService instead of panicking #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw-solana
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
LGTM.
I like the change to have separate receive/process at the top level too. This seems to better match the pattern we use elsewhere.
Would be good to wait for @fkouteib to review before merging since he spent more time here recently
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
…nza-xyz#3236) Raise the error and set validator exit flag to allow other threads to gracefully shutdown. Also add logs to indicate service start/stop
fkouteib
added a commit
to fkouteib/agave
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was reviewing #3026 post-merge and noticed we had a handful of
.expect()and.unwrap()inTransactionStatusService. These do not allow for graceful teardown of the process, so try to be nicer to other threads by initiating a more graceful teardownSummary of Changes
.expect()and.unwrap()One additional item I'll call out is that the panic hook pretty quickly kills the entire process via this:
agave/metrics/src/metrics.rs
Lines 538 to 539 in 7b05e29
The sentiment behind that comment is still valid. However, enough threads respect the exit flag such that the process will still come down fairly quickly so I think setting the flag is ok in this scenario