Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract cluster-type crate #3372

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Conversation

kevinheavey
Copy link

Problem

solana_sdk::genesis_config::ClusterType imposes a solana_sdk dep on solana_metrics. The genesis_config module is quite big when you include the other modules it pulls in, while solana_metrics only needs the ClusterType enum.

Summary of Changes

  • Move ClusterType into its own crate and re-export with deprecation notice

Copy link

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – indeed GenesisConfig brings lots of things that are not needed when only ClusterType is required, so it makes sense to separate them.

@febo
Copy link

febo commented Nov 11, 2024

@yihau Could we please accept the crate invite?

@yihau
Copy link
Member

yihau commented Nov 12, 2024

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 12, 2024
@febo febo merged commit 1d3925e into anza-xyz:master Nov 13, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants