Add CLI arg to control size of rayon global thread pool #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arg is hidden for now, and default behavior of one thread in the pool per system thread remains
steviez
force-pushed
the
val_cli_rayon_global
branch
from
3c32b45 to
aa20087
Compare
bw-solana
approved these changes
Oct 30, 2024
|
|
||
| fn default() -> usize { | ||
| get_max_thread_count() | ||
| } |
There was a problem hiding this comment.
Is 1 (the default) okay for the min here or should we bump it?
There was a problem hiding this comment.
I think it's ok - if someone specifies a bad value for a hidden argument that is on them IMO
On a somewhat related note, I think trying to get most operations (if not everything) out of the global pool is a good goal; the global pool is easy to use but given that anyone other service could be lighting it up with work, not great to have that uncertainty.
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
The arg is hidden for now, and default behavior of one thread in the pool per system thread remains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#105
Summary of Changes
The arg is hidden for now, and default behavior of one thread in the pool per system thread remains
To test, I: