Extract keccak-hasher crate #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-keccak-crate
branch
from
ac92137 to
b40649b
Compare
kevinheavey
force-pushed
the
extract-keccak-crate
branch
2 times, most recently
from
b16f644 to
8c2912d
Compare
kevinheavey
force-pushed
the
extract-keccak-crate
branch
from
8c2912d to
0688483
Compare
joncinque
reviewed
Nov 19, 2024
sdk/keccak-hasher/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| borsh = { workspace = true, optional = true } | ||
| bs58 = { workspace = true } |
There was a problem hiding this comment.
Since this is using solana-hash, I don't think this dependency is needed
sdk/keccak-hasher/src/lib.rs
Outdated
| solana_sanitize::Sanitize, | ||
| std::{convert::TryFrom, fmt, str::FromStr}, | ||
| thiserror::Error, | ||
| std::{fmt, str::FromStr}, |
There was a problem hiding this comment.
how about making this crate no_std like the hash crate? this can use core::{fmt, str::FromStr}. It can have an std feature which pretty much just enables the std feature on solana-hash
Comment on lines
+17
to
+21
| // TODO: replace this with `solana_hash::Hash` in the | ||
| // next breaking change. | ||
| // It's a breaking change because the field is public | ||
| // here and private in `solana_hash`, and making | ||
| // it public in `solana_hash` would break wasm-bindgen |
There was a problem hiding this comment.
Someone tried to combine all the hashes awhile ago, and we couldn't for this exact reason 🙃
sdk/keccak-hasher/Cargo.toml
Outdated
| bs58 = { workspace = true } | ||
| serde = { workspace = true, optional = true } | ||
| serde_derive = { workspace = true, optional = true } | ||
| solana-atomic-u64 = { workspace = true } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::keccakimposes asolana_programdep on some SPL cratesSummary of Changes
solana_program::keccakto a new cratesolana-keccak-hasher, modelled onsolana-sha256-hasher(see sdk: Extract hash and hasher crates #2015)Hashstruct withsolana_hash::Hashbut it won't be able to do so without a breaking change. In the meantime I've just made it rely onsolana_hashas much as possible while avoiding breakageThis branches off #3405 so that needs to be merged first (update: done)