perf: put test_tx.rs behind dev-context-only-utils #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
perf-test-tx-dcou
branch
from
e125a31 to
aaae917
Compare
yihau
approved these changes
Nov 4, 2024
kevinheavey
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This was clearly meant to be behind dev-context-only-utils already. The usage of
solana_sdk::transactionin test_tx.rs makes it harder to clean up the dependency tree too, which is not such a problem when test_tx.rs is behind dcou.Summary of Changes
Put the test_tx module behind dev-context-only-utils and update dependent crates accordingly