Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamer: put testing_utilities.rs behind dev-context-only-utils #3442

Merged

Conversation

kevinheavey
Copy link

Problem

As its name suggests, this module should be behind dev-context-only utils. This will also make it easier to remove the solana-sdk dependency

Summary of Changes

  • Put testing_utils.rs behind dcou
  • Update dependent crates accordingly

Copy link

@KirillLykov KirillLykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me since it is used only in the scope of integration and unit tests

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 2, 2024
@KirillLykov
Copy link

KirillLykov commented Nov 2, 2024

@kevinheavey Regarding this dev-context-only, am I right that any test-related code should be under this feature in any crate in agave? I didn't notice when and why it was introduced. But lets say I want to add some code that, again, will be used for integration and unit tests. Shall it be under this feature?

@kevinheavey
Copy link
Author

That is my understanding based on things @t-nelson has said

@mergify mergify bot merged commit 59bf0f0 into anza-xyz:master Nov 2, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants