remove solana-sdk from solana-streamer #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
streamer-rm-sdk
branch
2 times, most recently
from
9fa9909 to
550f78f
Compare
kevinheavey
force-pushed
the
streamer-rm-sdk
branch
from
fde4c6b to
7102579
Compare
|
@bw-solana Do you know who is the right person to review this PR? |
|
@KirillLykov are you able to review this one? |
KirillLykov
reviewed
Nov 14, 2024
KirillLykov
reviewed
Nov 14, 2024
|
Yeah I made the dev deps messier than necessary. Fixed them up in the latest commit |
KirillLykov
approved these changes
Nov 15, 2024
kevinheavey
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-streamer doesn't need to directly depend on solana-sdk
Summary of Changes
Replace solana-sdk in solana-streamer with its constituent crates
This branches off #3119 so that needs to be merged first (update: done)