Do not purge all bank snapshots after fastboot #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 842 842
Lines 228492 228491 -1
=========================================
- Hits 187104 187053 -51
- Misses 41388 41438 +50 |
brooksprumo
force-pushed
the
fastboot/ledger-tool
branch
from
69daadc to
edfe21d
Compare
brooksprumo
commented
Mar 28, 2024
Comment on lines
-301
to
-307
| // If the node crashes before taking the next bank snapshot, the next startup will attempt | ||
| // to load from the same bank snapshot again. And if `shrink` has run, the account storage | ||
| // files that are hard linked in bank snapshot will be *different* than what the bank | ||
| // snapshot expects. This would cause the node to crash again. To prevent that, purge all | ||
| // the bank snapshots here. In the above scenario, this will cause the node to load from a | ||
| // snapshot archive next time, which is safe. | ||
| snapshot_utils::purge_all_bank_snapshots(&snapshot_config.bank_snapshots_dir); |
There was a problem hiding this comment.
Now that #120 was merged, there are no more issues related to shrink. So this original concern has been mitigated.
Where was a second issue that purging all the bank snapshots here also fixed: solana-labs#35367. It has been fixed by #343, so now there are no more blockers to removing this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Please see solana-labs#35431
Summary of Changes
Do not purge all bank snapshots after fastbooting.
Fixes solana-labs#35431
Additional Testing
I ran leger-tool built from this PR on a mnb bank snapshot and confirmed I was able to repeatably use fastboot. Yay!
What's also really cool, is now that the storages recycler has been removed, we can fastboot from older bank snapshots as well; not just the latest.