Fixes accounts lt hash verification at startup #3465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When testing out accounts lt hash startup verification, if the accounts lt hash verification fails when running in the background, we don't panic/bring down the whole node.
This is because of the early returns.
After the background verification ends, we need to call
.background_finished()
. Otherwise we'll continue waiting on the result of the verification. I introduced the early returns in a previous PR, and so if the verification fails we'll never callbackground_finished()
and thus are never notified.Summary of Changes
Remove the early returns so that
background_finished()
is always called.