feature gate metrics usage in program-runtime #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinheavey you mentioned doing this doesn't really help your project without breaking up the SVM crate. Is there another direct reason this change should go into program-runtime? |
|
Yeah I realised can just copy paste what I need from the svm crate, so this would still be an improvement |
kevinheavey
force-pushed
the
program-runtime-metrics-feature-gate
branch
from
c892653 to
4ec02d1
Compare
|
Build times on my machine: Metrics feature enabled: 31 seconds |
kevinheavey
force-pushed
the
program-runtime-metrics-feature-gate
branch
from
4ec02d1 to
fcf7809
Compare
kevinheavey
force-pushed
the
program-runtime-metrics-feature-gate
branch
from
fcf7809 to
e9ff84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-program-runtime has an annoying solana-metrics dependency that severely impacts build time and dependency hell. It's particularly annoying for litesvm which depends on solana-program-runtime
Summary of Changes
Put solana-metrics behind a feature gate in solana-program-runtime. Activate the metrics feature for crates that should use it
Closes #3390