Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svm: introduce filter_executable_us metric (#3472) #3482

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

alessandrod
Copy link

Split the time taken by filter_executable_accounts() outside of program_cache_us. Filtering takes a considerable amount of time because account_matches_owners is pretty slow.

Manual backport of #3472 because I forgot the label

Split the time taken by filter_executable_accounts() outside of
program_cache_us. Filtering takes a considerable amount of time because
account_matches_owners is pretty slow.
@alessandrod alessandrod requested a review from a team as a code owner November 5, 2024 14:43
@alessandrod
Copy link
Author

I want to backport because it's just a metric change and makes it easier to watch metrics across master/2.1

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BP'ing a metric seems fine to me

@alessandrod alessandrod merged commit 95ee9c1 into anza-xyz:v2.1 Nov 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants