Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store epoch in MaxAge #3485

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Nov 5, 2024

Problem

  • MaxAge stores the last slot in the epoch which is confusing

Summary of Changes

  • Store Epoch instead

Fixes #

@apfitzge apfitzge force-pushed the scheduler_root_bank_features branch from 4fde707 to c86020c Compare November 5, 2024 17:06
@apfitzge apfitzge marked this pull request as ready for review November 5, 2024 18:59
@apfitzge apfitzge requested a review from jstarry November 5, 2024 18:59
@apfitzge apfitzge force-pushed the scheduler_root_bank_features branch from c86020c to 33f47ef Compare November 5, 2024 19:02
@apfitzge apfitzge added v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch labels Nov 6, 2024
@apfitzge apfitzge merged commit 5a6f518 into anza-xyz:master Nov 6, 2024
42 checks passed
Copy link

mergify bot commented Nov 6, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Nov 6, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Nov 6, 2024
(cherry picked from commit 5a6f518)

# Conflicts:
#	core/src/banking_stage/scheduler_messages.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state_container.rs
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
(cherry picked from commit 5a6f518)

# Conflicts:
#	core/src/banking_stage/consumer.rs
#	core/src/banking_stage/scheduler_messages.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state_container.rs
apfitzge added a commit that referenced this pull request Nov 7, 2024
* Store epoch in MaxAge (#3485)

(cherry picked from commit 5a6f518)

# Conflicts:
#	core/src/banking_stage/scheduler_messages.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state_container.rs

* resolve conflicts

---------

Co-authored-by: Andrew Fitzgerald <[email protected]>
apfitzge added a commit that referenced this pull request Nov 7, 2024
* Store epoch in MaxAge (#3485)

(cherry picked from commit 5a6f518)

# Conflicts:
#	core/src/banking_stage/consumer.rs
#	core/src/banking_stage/scheduler_messages.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state_container.rs

* resolve conflicts

---------

Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants