Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: program-runtime: double program cache size (backport of #3481) #3494

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 6, 2024

The cache is currently getting thrashed and programs are getting reloaded pretty much at every single slot. Double the cache size, which makes reloading happen only due to random eviction sometimes picking a popular entry.

The JIT code size with the new cache size is about 800MB.

This change reduces JIT time 15x.

Left is with PR, right is master.

Screenshot 2024-11-05 at 8 46 59 pm
This is an automatic backport of pull request #3481 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner November 6, 2024 04:17
@alessandrod alessandrod force-pushed the mergify/bp/v2.0/pr-3481 branch from f96dfcd to dabb8c4 Compare November 8, 2024 05:23
The cache is currently getting thrashed and programs are getting
reloaded pretty much at every single slot. Double the cache size, which
makes reloading happen only due to random eviction sometimes picking a
popular entry.

The JIT code size with the new cache size is about 800MB.

This change reduces jit time 15x.

(cherry picked from commit fb4adda)
@alessandrod alessandrod force-pushed the mergify/bp/v2.0/pr-3481 branch from dabb8c4 to 7c290fc Compare November 8, 2024 08:50
@alessandrod alessandrod merged commit 2408949 into v2.0 Nov 9, 2024
38 checks passed
@alessandrod alessandrod deleted the mergify/bp/v2.0/pr-3481 branch November 9, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants