v2.0: Fix broken parallelism in quic-client (backport of #2526) #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix broken parallelism in quic-client Fixes excessive fragmentation by TPU clients leading to a large number of streams per conn in 'sending' state simultaneously. This, in turn, requires excessive in-memory buffering server-side to reassemble fragmented transactions. - Simplifies QuicClient::send_batch to enqueue send operations in sequential order - Removes the "max_parallel_streams" config option The quic-client now produces an ordered fragment stream when scheduling send operations from a single-thread. * quic-client: remove outdated test --------- Co-authored-by: Richard Patel <[email protected]> Co-authored-by: Alessandro Decina <[email protected]> (cherry picked from commit 76cbf1a)
t-nelson
approved these changes
Nov 21, 2024
alessandrod
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I'm approving this because it improves things. To fix the issue we'd still need to backport #3672 which I think we should do at some point soon, but let's bake that quinn version a little longer on other channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes excessive fragmentation by TPU clients leading to a large
number of streams per conn in 'sending' state simultaneously.
This, in turn, requires excessive in-memory buffering server-side
to reassemble fragmented transactions.
in sequential order
The quic-client now produces an ordered fragment stream when
scheduling send operations from a single-thread.
This is an automatic backport of pull request #2526 done by [Mergify](https://mergify.com).