Extract client-traits crate #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @kevinheavey. |
This was referenced Nov 29, 2024
kevinheavey
force-pushed
the
extract-client-traits
branch
from
4d59e85 to
5441a7f
Compare
kevinheavey
force-pushed
the
extract-client-traits
branch
from
5441a7f to
cd8936c
Compare
joncinque
reviewed
Dec 5, 2024
sdk/client-traits/src/lib.rs
Outdated
| solana_hash::Hash, | ||
| solana_instruction::Instruction, | ||
| solana_keypair::Keypair, | ||
| solana_program::{message::Message, system_instruction::transfer}, |
There was a problem hiding this comment.
Let's use solana_message and solana_system_interface to remove the solana-program dependency
sdk/client-traits/Cargo.toml
Outdated
| solana-hash = { workspace = true } | ||
| solana-instruction = { workspace = true } | ||
| solana-keypair = { workspace = true } | ||
| solana-program = { workspace = true } |
There was a problem hiding this comment.
Same here: solana-message / solana-system-interface instead
joncinque
approved these changes
Dec 5, 2024
kevinheavey
force-pushed
the
extract-client-traits
branch
from
65f0ce5 to
33931bb
Compare
yihau
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::clientimposes asolana_sdkdep onsolana_rpc_clientSummary of Changes
Move to its own crate and re-export with deprecation
This branches off #3634 so that needs to be merged first (update: done)