remove solana-sdk from rpc-client #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @kevinheavey. |
kevinheavey
force-pushed
the
rpc-client-rm-sdk
branch
from
4e72201 to
fbcf2e5
Compare
kevinheavey
force-pushed
the
rpc-client-rm-sdk
branch
4 times, most recently
from
3f21340 to
5ce400a
Compare
kevinheavey
force-pushed
the
rpc-client-rm-sdk
branch
from
1578b8b to
282e597
Compare
joncinque
approved these changes
Dec 6, 2024
| @@ -1355,11 +1346,11 @@ impl RpcClient { | |||
| /// and the transaction failed, this method returns `Ok(Some(Err(_)))`, | |||
| /// where the interior error is type [`TransactionError`]. | |||
| /// | |||
| /// [`TransactionError`]: solana_sdk::transaction::TransactionError | |||
| /// [`TransactionError`]: solana_transaction_error::TransactionError | |||
There was a problem hiding this comment.
I didn't realize how smart this is -- it actually currently resolves back to solana_transaction_error::TransactionError 🥳
Either way, it's definitely better to use the base import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This crate can compile faster without solana-sdk
Summary of Changes
Remove it and replace with constituent crates as appropriate
This branches off #3634 so that needs to be merged first (update: done)