move program::wasm::instructions to instruction crate #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Just a tiny nit, looks good otherwise! I tried to see if we could do this more cleverly by changing the Transaction wasm constructor to take something like Into<Vec<Instruction>> but wasm-bindgen doesn't support generics. So I think your approach is the best option.
joncinque
approved these changes
Dec 3, 2024
joncinque
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::wasm::instructionsimposes asolana-programdep onsolana-transaction(which is getting pulled out in #3634. The contents of instructions.rs are a legacy solution because wasm_bindgen now supports Vec, but until we make a breaking change,solana-transactionrequires instructions.rsSummary of Changes