[runtime-transaction] add secp256r1 to precompile signature details #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
runtime-transaction/secp256r1
branch
from
431401b to
1ea4e37
Compare
samkim-crypto
force-pushed
the
runtime-transaction/secp256r1
branch
from
1ea4e37 to
3f503c6
Compare
LucasSte
previously approved these changes
Dec 3, 2024
buffalojoec
reviewed
Dec 3, 2024
| @@ -140,26 +150,31 @@ mod tests { | |||
| Pubkey::new_unique(), | |||
| solana_sdk::secp256k1_program::ID, | |||
| solana_sdk::ed25519_program::ID, | |||
| solana_secp256r1_program::ID, | |||
There was a problem hiding this comment.
Ahh bummer, is this ID not included in the SDK anywhere? Would avoid the dependency.
There was a problem hiding this comment.
Maybe worth adding the ID to sdk in this PR.
There was a problem hiding this comment.
Oh sorry I missed this. I replace all solana_secp256r1_program with solana_sdk_ids::secp256r1_program.
samkim-crypto
force-pushed
the
runtime-transaction/secp256r1
branch
from
49eabc4 to
c47cfe6
Compare
|
Updated! and the CI seems to pass! |
buffalojoec
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The secp256r1 precompile (#3152) was added, but the logic in some of the crates in the monorepo such as
runtime-transactiondoes not yet account for the new precompile.Summary of Changes
Added a secp256r1 signatures field to the main types in the
runtime-transaction.The actual costs for the new precompile has to be added to the
cost-modelcrate, but I will do it on a follow-up.Fixes #