v2.1: feat: deplete compute meter for vm errors (backport of #3751) #3955
+248
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
the
feature-gate
|
The Firedancer team maintains a line-for-line reimplementation of the |
t-nelson
previously approved these changes
Dec 6, 2024
bw-solana
force-pushed
the
mergify/bp/v2.1/pr-3751
branch
3 times, most recently
from
d2d43b7 to
3dd7668
Compare
* feat: deplete compute meter for vm errors * add tests * rekey apply_cost_tracker_during_replay (cherry picked from commit b120fc1)
bw-solana
force-pushed
the
mergify/bp/v2.1/pr-3751
branch
from
bc001d0 to
4893047
Compare
bw-solana
approved these changes
Dec 13, 2024
|
this needs sme approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Implements SIMD-0182 by making sure that programs that fail with VM errors consume the remaining compute budget to simplify compute unit handling.
Summary of Changes
Feature Gate Issue: solana-labs#29595
This is an automatic backport of pull request #3751 done by [Mergify](https://mergify.com).