Simplify check for data Rc in account info data and improve tesing #4046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sol_invoke_signed_rust() takes an slice of AccountInfo. The account data field is defined as a Rc<RefCell<&mut [u8]>. This means that the AccountInfo struct holds a single pointer for the data field, which points to a struct containing:
account_info.data.as_ptr() gives as the pointer to the data field of the Rc<RefCell<>> struct, not the data pointer itself; it's the data of the RefCell.
The check for the offset of the length field is therefore redundant and therefore removed.
Also improve the test which show UB without the checks we added in #3471