ci: unify solana docker base image #4052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
sdk-use-ubuntu
branch
2 times, most recently
from
3e319b1 to
ef5444f
Compare
yihau
force-pushed
the
sdk-use-ubuntu
branch
from
ef5444f to
f1c7ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we use 2 different docker based images
ci:
agave/ci/docker/env.sh
Line 13 in 8c3a6bb
sdk:
agave/sdk/docker-solana/Dockerfile
Line 1 in 8c3a6bb
this won't be an issue if the sdk and ci were standalone components. however, they are interconnected. the sdk relies on the ci image to build bins. it means the sdk's base image should be compatible with ci's
we are using ubuntu in lots of places. would like to get sdk use it as well.
Summary of Changes
migrate sdk's docker base image from
debiantoubuntu