uses serde_bytes for (de)serializing Vec<u8> #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Vec<u8> is treated just as any Vec<T> and is inefficiently (de)serialized byte by byte. serde_bytes instead uses Serializer::serialize_bytes and Deserializer::deserialize_bytes which do so more efficiently. https://docs.rs/serde/latest/serde/trait.Serializer.html#tymethod.serialize_bytes https://docs.rs/serde/latest/serde/trait.Deserializer.html#tymethod.deserialize_bytes
behzadnouri
force-pushed
the
serde-bytes-all
branch
from
bdecf60 to
7eb9c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
By default
Vec<u8>is treated just as anyVec<T>and is inefficiently (de)serialized byte by byte.serde_bytesinstead usesSerializer::serialize_bytesandDeserializer::deserialize_byteswhich do so more efficiently.https://docs.rs/serde/latest/serde/trait.Serializer.html#tymethod.serialize_bytes
https://docs.rs/serde/latest/serde/trait.Deserializer.html#tymethod.deserialize_bytes
Summary of Changes
The commit uses
serde_bytesfor (de)serializingVec<u8>.