Obsolete uncleaned_roots in accounts index.
#4092
Open
+70
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
changed the title
uncleaned_roots in accounts index.
brooksprumo
reviewed
Dec 13, 2024
brooksprumo
reviewed
Dec 13, 2024
HaoranYi
force-pushed
the
remove_uncleaned_root
branch
from
daa833f to
3133d8e
Compare
brooksprumo
reviewed
Dec 13, 2024
brooksprumo
reviewed
Dec 16, 2024
HaoranYi
force-pushed
the
remove_uncleaned_root
branch
from
6ba07a4 to
0eb57e4
Compare
|
Rebase to pick up #4147. |
brooksprumo
reviewed
Dec 16, 2024
brooksprumo
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
I think it'd be good to get @jeffwashington to double check as well
|
The following graph shows the number of open append_vec from dev2, which are running with this PR for two days on mainnet. These numbers look normal.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In PR#4044, we no longer filter clean by
uncleaned_roots. All slots that are older than themax_root_to_cleanare considered in clean.The concept of
uncleaned_rootsis now obsolete. And we should remove it.Summary of Changes
Remove
uncleaned_rootsfrom account index.Fixes #